Fix zoom to cursor #206
Merged
Fix zoom to cursor #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches mouse wheel behavior to dolly instead of zoom This allows the dollyToCursor prop to do its thing
ghsteff
commented
Mar 14, 2024
| @@ -224,7 +224,7 @@ export const CameraControls: FC< | |||
| } else { | |||
| cameraRef.current.mouseButtons.left = 2; | |||
| cameraRef.current.mouseButtons.middle = 2; | |||
| cameraRef.current.mouseButtons.wheel = 16; | |||
| cameraRef.current.mouseButtons.wheel = ThreeCameraControls.ACTION.DOLLY; | |||
There was a problem hiding this comment.
this is the same as cameraRef.current.mouseButtons.wheel = 8, but I figured this was clearer
could also update the above to
cameraRef.current.mouseButtons.left = ThreeCameraControls.ACTION.TRUCK;
cameraRef.current.mouseButtons.middle = ThreeCameraControls.ACTION.TRUCK;
There was a problem hiding this comment.
oh also just found a bug where the camera's not disabled when disabled is true
I have a little fix, lmk if I should push it into here. It's not really related
amcdnl
approved these changes
Mar 14, 2024
amcdnl
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The camera only zooms towards the center of the graph
Issue Number: #200
What is the new behavior?
When zooming with your mousewheel, the camera zooms towards the cursor
Does this PR introduce a breaking change?
Other information
This switches mouse wheel behavior to dolly instead of zoom
This allows the
dollyToCursorprop to do its thingScreen.Recording.2024-03-14.at.9.53.13.AM.mov